Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(maint) Change curl to import the text from a file #1

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

AdmiringWorm
Copy link
Member

Description Of Changes

This change allows files that contain text that is longer than what is
allowed to be passed in through the commandline to still work.

The drawback of this approach is that the action takes longer to go
through all of the files in the repository.

Motivation and Context

To be able to run this action on our documentation repositories.

Testing

  1. It was tested manually in one of my personal repositories through GitHub.
  2. Not found a way to test this locally.

Operating Systems Testing

N/A

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v2 compatibility checked?

Related Issue

N/A

This change allows files that contain text that is longer than what is
allowed to be passed in through the commandline to still work.

The drawback of this approach is that the action takes longer to go
through all of the files in the repository.
@pauby
Copy link
Member

pauby commented Oct 20, 2023

@AdmiringWorm This looks fine to me, but I have no way to test it currently. I am happy to go with your testing and take responsibility if it all falls apart 😄

Are you happy for me to merge it?

@AdmiringWorm
Copy link
Member Author

@pauby yeah. I am happy for you to merge this change.

@pauby pauby merged commit 1ebece1 into chocolatey:develop Nov 8, 2023
7 checks passed
@pauby
Copy link
Member

pauby commented Nov 8, 2023

@AdmiringWorm awesome work! Thanks for your contribution!

@AdmiringWorm AdmiringWorm deleted the file-import branch February 12, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants